add more clear types for getBranchInfo

268685ca2b2d95435aef7ae0cae6328464f07903

Tucker McKnight <tucker@pangolin.lan> | Mon Nov 03 2025

add more clear types for getBranchInfo
main.ts:15
Before
15
export default async function repoViewer(eleventyConfig, reposConfiguration: ReposConfiguration) {
After
15
export default async function repoViewer(eleventyConfig: any, reposConfiguration: ReposConfiguration) {
main.ts:34
Before
34
  eleventyConfig.addFilter("getFileName", (filePath) => {
After
34
  eleventyConfig.addFilter("getFileName", (filePath: string) => {
src/dataTypes.ts:1
Before
1
type Repository = {
After
1
export type Repository = {
src/helpers.ts:1
Before
1
After
1
import {type Repository} from './dataTypes.ts'
src/helpers.ts:14
Before
14
15
16
17
18
19
20
21
type DiffInfo = {
  file: string,
  lineNumber: number,
  previousText: string,
  afterText: string,
}
const getGitDiffsFromPatchText = (patchText: string): Array<DiffInfo> => {
  const hunks: Array<Hunk> = []
After
14
15
16
17
18
19
20
21
type Diffs = ReturnType<Repository['commits']['get']>['diffs']

const getGitDiffsFromPatchText = (patchText: string): Diffs => {
  const hunks: Diffs = []
src/helpers.ts:55
Before
55
56
57
58
59
      let previousText = ""
          previousText = previousText + obj.value
          previousText = previousText + "<mark>" + obj.value + "</mark>"
        file: previousFilename !== '' ? previousFilename : currentFilename,
        previousText,
After
55
56
57
58
59
      let beforeText = ""
          beforeText = beforeText + obj.value
          beforeText = beforeText + "<mark>" + obj.value + "</mark>"
        fileName: previousFilename !== '' ? previousFilename : currentFilename,
        beforeText,
src/repos.ts:4
Before
4
After
4
import { getBranchInfo } from './vcses/git/operations.ts'
src/repos.ts:35
Before
35
      const patches = await repoOperations[vcs].getBranchInfo(repoName, branchName, repoLocation)
After
35
      const patches = await getBranchInfo(branchName, repoLocation)
src/vcses/git/operations.ts:2
Before
2
After
2
import { type Repository } from '../../dataTypes.ts'
src/vcses/git/operations.ts:37
Before
37
38
export const getBranchInfo = async (repoName: string, branchName: string, repoLocation: string) => {
  const patches = new Map()
After
37
38
export const getBranchInfo = async (branchName: string, repoLocation: string) => {
  const patches: Map<string, {
    name: string,
    description: string,
    author: string,
    date: string,
    hash: string,
    diffs: ReturnType<Repository['commits']['get']>['diffs'],
  }> = new Map()
src/vcses/git/operations.ts:54
Before
54
      let author, date
After
54
      let author: string, date: string
src/vcses/operations.ts:1
Before
1
  getBranchInfo as getGitBranchInfo,
After
1
src/vcses/operations.ts:7
Before
7
    getBranchInfo: (repoName: string, branchName: string, repoLocation: string) => Promise<BranchInfo['patches']>,
After
7
src/vcses/operations.ts:15
Before
15
    getBranchInfo: getGitBranchInfo,
After
15
templates/patch.njk:27
Before
27
28
29
      <span class="font-monospace fw-bold"><a href="{{reposPath}}/{{patchInfo.repoName | slugify}}/branches/{{patchInfo.branchName | slugify}}/files/{{ hunk.file | slugify}}.html">{{ hunk.file }}:{{ hunk.lineNumber }}</a></span>
{%- for lineNumber in hunk.previousText | lineNumbers -%}
              <pre data-start="{{hunk.lineNumber}}"><code data-type="before" class="line-numbers language-{{hunk.file | languageExtension(patchInfo.repoName)}}">{{hunk.previousText | safe}}</code></pre>
After
27
28
29
      <span class="font-monospace fw-bold"><a href="{{reposPath}}/{{patchInfo.repoName | slugify}}/branches/{{patchInfo.branchName | slugify}}/files/{{ hunk.fileName | slugify}}.html">{{ hunk.fileName }}:{{ hunk.lineNumber }}</a></span>
{%- for lineNumber in hunk.beforeText | lineNumbers -%}
              <pre data-start="{{hunk.lineNumber}}"><code data-type="before" class="line-numbers language-{{hunk.fileName | languageExtension(patchInfo.repoName)}}">{{hunk.beforeText | safe}}</code></pre>
templates/patch.njk:55
Before
55
              <pre data-start="{{hunk.lineNumber}}"><code data-type="after" class="line-numbers language-{{hunk.file | languageExtension(patchInfo.repoName)}}">{{ hunk.afterText | safe}}</code></pre>
After
55
              <pre data-start="{{hunk.lineNumber}}"><code data-type="after" class="line-numbers language-{{hunk.fileName | languageExtension(patchInfo.repoName)}}">{{ hunk.afterText | safe}}</code></pre>